Memoize stateStream #9411
Merged
Memoize stateStream #9411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
hrb-hub
approved these changes
Jul 30, 2025
04e9c4e to
9aa63bc
Compare
This improves readability slightly.
This occurs because the list of mailboxes in MailboxModel is outdated, and LoginFacade bypasses cache to get a new User, thus if we lose access to any groups, their cached entities will be lost, thus whenever we try to load mailsets, we cache miss and try to fetch from the server (which fails as we have no access to those lists now). Closes #9143
We were not actually deleting the database on membership removal when we used to (this was broken when we added sqlite full-text search). Closes #9143
domainStatus is not valid for renderCheckResult once we reload it. Closes #6818
It's just used for determining whether or not to show a custom header bar. We can just use headerBarAttrs for this.
Unless the state stream was changed for some reason on the list model, we do not need to make a new state stream (and thus re-run the same computations over and over on an unchanged state). Closes #9404
9aa63bc to
d8b339b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless the state stream was changed for some reason on the list model, we do not need to make a new state stream (and thus re-run the same computations over and over on an unchanged state).
Closes #9404