Fix external image replacement serialization #9467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chromium changed how HTML is serialized: https://developer.chrome.com/release-notes/138? https://chromestatus.com/feature/6264983847174144 whatwg/html#6235 Which caused some of our HTML sanitizing tests to fail. To prevent any possible issues with serialization we instead create a Blob URL for our svg. This way we sidestep DOM serialization peculiarities. As a side effect DOM should be smaller. Close #9465 Co-authored-by: paw <paw-hub@users.noreply.github.com>
11 tasks
wrdhub
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chromium changed how HTML is serialized:
https://developer.chrome.com/release-notes/138?
https://chromestatus.com/feature/6264983847174144
whatwg/html#6235
Which caused some of our HTML sanitizing tests to fail.
To prevent any possible issues with serialization we instead create a Blob URL for our svg. This way we sidestep DOM serialization peculiarities. As a side effect DOM should be smaller.
Close #9465