Enable stricter eslint rules #9336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murilopereirame
approved these changes
Jul 18, 2025
andrehgdias
reviewed
Jul 18, 2025
| @@ -81,7 +81,7 @@ export class CalendarAgendaView implements Component<CalendarAgendaViewAttrs> { | |||
|
|
|||
| const agendaChildren = this.renderAgenda(attrs, isDesktopLayout) | |||
|
|
|||
| if (attrs.selectedTime && attrs.eventsForDays.size > 0 && this.lastScrolledDate != attrs.selectedDate) { | |||
| if (attrs.selectedTime && attrs.eventsForDays.size > 0 && this.lastScrolledDate !== attrs.selectedDate) { | |||
There was a problem hiding this comment.
We might need to use getTime()
There was a problem hiding this comment.
new Date(0) === new Date(0) // false
new Date(0) == new Date(0) // falsewe should have done it before too, huh?
| @@ -216,7 +222,7 @@ function expandByDayRuleForWeeklyEvents(targetWeekDay: any, date: DateTime, wkst | |||
| newDate = newDate.plus({ weeks: 1 }) | |||
| } | |||
|
|
|||
| if (newDate.toMillis() >= nextEvent || (wkst != WeekDaysJsValue.MO && newDate.toMillis() >= intervalStart.plus({ weeks: 1 }).toMillis())) { | |||
| if (newDate.toMillis() >= nextEvent || (wkst !== WeekDaysJsValue.MO && newDate.toMillis() >= intervalStart.plus({ weeks: 1 }).toMillis())) { | |||
There was a problem hiding this comment.
This comparison is using the wrong enum, wkst should be compared against WeekdayNumbers
There was a problem hiding this comment.
ah, good catch! could you push up a fix? I'm not sure I know how to fix it
vitoreiji
approved these changes
Jul 21, 2025
wrdhub
approved these changes
Jul 22, 2025
Close #9333 Co-authored-by: hrb-hub <hrb-hub@users.noreply.github.com>
Co-authored-by: hrb-hub <hrb-hub@users.noreply.github.com>
Co-authored-by: hrb-hub <hrb-hub@users.noreply.github.com>
…ries with ByDay rules and weekstart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9333