Undo move mail #9313
Merged
Undo move mail #9313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlag
reviewed
Jul 18, 2025
charlag
reviewed
Jul 18, 2025
548418c to
f6d7708
Compare
This was
linked to
issues
Jul 18, 2025
Closed
1fe8ab4 to
442a3e5
Compare
wrdhub
reviewed
Jul 22, 2025
There was a problem hiding this comment.
A couple things I noticed when smoke testing:
- There is a report spam setting and when it is set to "Always ask" a dialog appears asking if you want to report. Right now this dialog only shows after the ten seconds of the undo snackbar is up. This is jarring and disconnects the dialog from the action of moving mail to Spam. The dialog should show right after a mail is moved.
- How hard would it be to keep the snackbar if it is hovered? It can be frustrating for it to disappear right from under your cursor. I would propose that it should stay if the action button is being hovered. (This does not need to be done right now, we can discuss and make an issue later.)
wrdhub
approved these changes
Jul 29, 2025
578f6b5 to
187a17e
Compare
wrdhub
requested changes
Aug 1, 2025
Show a snackbar that can undo moving mails. The user can click "Undo" or press CTRL-Z (CMD-Z) to undo moving mails. If they do, this will move the mails back and close the snackbar. Additionally, if the mails were to be reported as spam, they won't be reported, either. Removed the reporting snackbar and added a new message specifically for mails being moved to spam. Close #9321 Close #9319 Close #9318 Close #9312 Close #9205 Close #9386 Close #9428 Co-authored-by: paw <paw-hub@users.noreply.github.com> Co-authored-by: hrb-hub <hrb-hub@users.noreply.github.com>
4e5e79d to
9602eae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #9205