Temporarily close the dns checker when loading new results #9377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlag
approved these changes
Jul 28, 2025
This improves readability slightly.
This occurs because the list of mailboxes in MailboxModel is outdated, and LoginFacade bypasses cache to get a new User, thus if we lose access to any groups, their cached entities will be lost, thus whenever we try to load mailsets, we cache miss and try to fetch from the server (which fails as we have no access to those lists now). Closes #9143
We were not actually deleting the database on membership removal when we used to (this was broken when we added sqlite full-text search). Closes #9143
domainStatus is not valid for renderCheckResult once we reload it. Closes #6818
It's just used for determining whether or not to show a custom header bar. We can just use headerBarAttrs for this.
23d135e to
727ae20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
domainStatus is not valid once we reload it.
Closes #6818