Skip to content

Add the missing params for tool get_table_schema #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

Add the missing params for tool get_table_schema #54

merged 1 commit into from
Jun 25, 2025

Conversation

frdeng
Copy link
Contributor

@frdeng frdeng commented Jun 21, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • New Features
    • Added support for optional "catalog" and "schema" parameters when retrieving table schema, allowing for more precise queries.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jun 21, 2025 •
edited
Loading

Walkthrough

The update modifies the registration of the "get_table_schema" tool in the MCP server by introducing two new optional string parameters, "catalog" and "schema," in addition to the existing "table" parameter. No other logic or control flow is changed.

Changes

File(s) Change Summary
cmd/main.go Added optional "catalog" and "schema" string parameters to the "get_table_schema" tool registration.

Poem

In the server's code, new options appear—
"Catalog" and "schema" now join the cheer.
With tables and columns, the queries expand,
More choices for data, just as we planned.
A hop and a skip, the schema’s in sight,
Rabbits rejoice—everything’s right! 🐇

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (1.64.8)

Error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2
Failed executing command with error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Jun 21, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
cmd/main.go (1)

172-173: Verify handler implementation supports the new parameters.

The addition of optional catalog and schema parameters makes logical sense and aligns with Trino's hierarchical table identification (catalog.schema.table). This change also brings consistency with other tools like list_tables that already accept these parameters.

However, ensure that the h.GetTableSchema handler implementation has been updated to process these new optional parameters.

#!/bin/bash
# Description: Verify that the GetTableSchema handler method supports catalog and schema parameters
# Expected: The handler should accept and process catalog/schema parameters from the tool arguments

# Search for the GetTableSchema handler implementation
ast-grep --pattern 'func ($$$) GetTableSchema($$$) $$$'

# Also search for any parameter processing within the handler
rg -A 10 -B 5 "GetTableSchema"

Consider enhancing the parameter descriptions for better clarity:

-		mcp.WithString("catalog", mcp.Description("Catalog")),
-		mcp.WithString("schema", mcp.Description("Schema")),
+		mcp.WithString("catalog", mcp.Description("Trino catalog name (optional)")),
+		mcp.WithString("schema", mcp.Description("Schema name within the catalog (optional)")),
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5d2065f and 2dcd273.

📒 Files selected for processing (1)
  • cmd/main.go (1 hunks)

@tuannvm
Copy link
Owner

tuannvm commented Jun 25, 2025

@frdeng could you sign DCO? See https://github.com/tuannvm/mcp-trino/pull/54/checks?check_run_id=44515115938

Thanks!

@tuannvm tuannvm merged commit d1fb1a6 into tuannvm:main Jun 25, 2025
2 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Jul 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frdeng @tuannvm