Skip to content

Upgrade to go go-1.13 #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 17, 2019
Merged

Upgrade to go go-1.13 #242

merged 3 commits into from
Sep 17, 2019

Conversation

dpordomingo
Copy link
Contributor

@dpordomingo dpordomingo commented Sep 13, 2019 •
edited
Loading

fix #198
fix #238

According to our conventions, we should update to last go version

  • I have updated the CHANGELOG file according to the conventions in keepachangelog.com
  • This PR contains changes that do not require a mention in the CHANGELOG file

@dpordomingo dpordomingo added the enhancement New feature or request label Sep 13, 2019
@dpordomingo dpordomingo self-assigned this Sep 13, 2019
@carlosms carlosms mentioned this pull request Sep 16, 2019
Closed
@dpordomingo dpordomingo changed the title [WIP] Upgrade to go go-1.13 Upgrade to go go-1.13 Sep 16, 2019
@dpordomingo dpordomingo requested a review from a team September 16, 2019 07:30
@dpordomingo dpordomingo mentioned this pull request Sep 16, 2019
Closed
@carlosms
Copy link
Contributor

Reading the release notes, it looks like we need to update go.mod in order to use 1.13 language features:
https://golang.org/doc/go1.13#language

@dpordomingo
Copy link
Contributor Author

good catch @carlosms!
Done by 79b119b#diff-37aff102a57d3d7b797f152915a6dc16R3

carlosms
carlosms reviewed Sep 16, 2019
View reviewed changes
@dpordomingo
Upgrade to go go-1.13
484e547 
According to our conventions we should update to last go version

Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
@dpordomingo
Remove unnecessary GO111MODULE=on in Travis for go1.13
3cf0c4c 
In go 1.13, GO111MODULE=auto activates the module-aware mode of the go command
when the the current working directory contains, or is below a directory containing go.mod
also when in /projects.

Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
@dpordomingo
Update CHANGELOG. sourced requires go1.13
40e8686 
Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
@dpordomingo dpordomingo merged commit 2585276 into src-d:master Sep 17, 2019
@dpordomingo dpordomingo deleted the upgrade-go branch September 17, 2019 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@carlosms carlosms carlosms approved these changes

@se7entyse7en se7entyse7en se7entyse7en approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@dpordomingo dpordomingo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to go-1.13 Add GOPROXY to travis
3 participants
@dpordomingo @carlosms @se7entyse7en