Skip to content

Conversation

carlosms
Copy link
Contributor

Close #78.


  • I have updated the CHANGELOG file according to the conventions in keepachangelog.com
  • This PR contains changes that do not require a mention in the CHANGELOG file

@carlosms carlosms requested a review from a team August 19, 2019 16:26
docs/faq.md Outdated
@@ -137,3 +137,7 @@ the [Architecture documentation](./architecture.md#docker-networking)
The user interface is based in the open-sourced [Apache Superset](http://superset.apache.org),
so you can also refer to [Superset tutorials](http://superset.apache.org/tutorial.html)
for advanced usage of the web interface.

## I Get IOError: [Errno 13] Permission denied: u'./.env'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link may not work both in git and GotBook. Could you try in GitBook?
What if using something like the following instead?

Suggested change
## I Get IOError: [Errno 13] Permission denied: u'./.env'
## I Get IOError Errno 13 Permission denied

Copy link
Contributor

@dpordomingo dpordomingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we also mention this limitation when explaining source{d} dependencies?
https://github.com/src-d/sourced-ce/blob/master/docs/quickstart/1-install-requirements.md#install-docker
I'd mention it when saying that docker toolbox is not allowed.

docs/faq.md Outdated

## I Get IOError: [Errno 13] Permission denied: u'./.env'

This may happen if you have installed Docker from a snap package. This installation mode is not supported, please install it following [the official documentation](https://docs.docker.com/install/) (See [#78](https://github.com/src-d/sourced-ce/issues/78)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if linking our docs about how to install docker? We already provide some links to the different OS.

@carlosms
Copy link
Contributor Author

@dpordomingo I have pushed changes for all you suggestions

Copy link
Contributor

@dpordomingo dpordomingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Many thanks @carlosms

Signed-off-by: Carlos Martín <carlos.martin.sanchez@gmail.com>
@carlosms carlosms merged commit fd4da1f into src-d:master Aug 20, 2019
@carlosms carlosms deleted the faq-snap-pck branch August 20, 2019 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error executing sourced init when docker is installed using snap
4 participants