Skip to content

Make sourced-ui to depend on bblfsh-web #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2019
Merged

Make sourced-ui to depend on bblfsh-web #136

merged 1 commit into from
Jul 10, 2019

Conversation

dpordomingo
Copy link
Contributor

@dpordomingo dpordomingo commented Jul 10, 2019 •
edited
Loading

Considering container dependencies in docker-compose:

  • sourced-ui should require bblfsh-web,
  • sourced-ui does not directly depend on ghsync

@dpordomingo
Make sourced-ui to depend on bblfsh-web
da029ea 
Signed-off-by: David Pordomingo <david.pordomingo.f@gmail.com>
@dpordomingo dpordomingo added the bug Something isn't working label Jul 10, 2019
@dpordomingo dpordomingo requested a review from a team July 10, 2019 04:37
@dpordomingo dpordomingo self-assigned this Jul 10, 2019
@dpordomingo dpordomingo merged commit ee6ca33 into master Jul 10, 2019
@dpordomingo dpordomingo deleted the dpordomingo-sourced-ui-dep branch July 10, 2019 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@carlosms carlosms carlosms approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@dpordomingo dpordomingo

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dpordomingo @carlosms