Skip to content

Integration tests broken on windows due to Maximum Path Length Limitation #191

@se7entyse7en

Description

@se7entyse7en

Caused by #189.

In Windows, there's a Maximum Path Length Limitation (source), and during integration tests, this limit is reached.

This is the path of the docker-compose.yml file:

C:\Users\Windows10\AppData\Local\Temp\TestInitLocalTestSuite_TestChangeWorkdir131516411\sourced\workdirs\local\QzpcVXNlcnNcV2luZG93czEwXEFwcERhdGFcTG9jYWxcVGVtcFxUZXN0SW5pdExvY2FsVGVzdFN1aXRlX1Rlc3RDaGFuZ2VXb3JrZGlyMTMxNTE2NDExXHdvcmtkaXJfYQ==\docker-compose.yml

whose length is 262. I tried to rename the test name to the shorter TestChWD and all the tests pass. The effect of this limitation can also be seen by cd-ing in the directory and try to run docker-compose from there. Even in this case docker-compose fails to see the docker-compose.yml file. Even simply catting the file fails.

For normal uses, this shouldn't be very likely to happen, but still, it could. We could add a limit to the generated b64 string, and this would require changing the way we retrieve the human-friendly name of the workdir. With the current .env file we already have the followings:

  • GITBASE_VOLUME_SOURCE key for local initialization,
  • GITHUB_ORGANIZATIONS key for orgs initialization.

Maybe we could add a more explicit key such as WORKDIR_SUBJECT or WORKDIR_WHATEVER.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions