Skip to content

Conversation

carlosms
Copy link
Contributor

From the conversation in #624.

The comments contained an empty analzyer-name field:

$ lookout-sdk review --from HEAD^ --log-format=json 2> log.err
{"analyzer-name":"","file":"cmd/lookout-sdk/push.go","text":"The file has increased in 2 lines."}

In lookoutd the name is taken from the config file. With this PR lookout-sdk fills the info that would be extracted from that lookout.yml config file.

$ lookout-sdk review --log-level=error
{"analyzer-name":"test-analyzer","file":"cmd/lookout-sdk/event.go","text":"The file has increased in 8 lines."}
{"analyzer-name":"test-analyzer","file":"cmd/lookout-sdk/event.go","line":29,"text":"This line exceeded 120 chars."}

Signed-off-by: Carlos Martín <carlos.martin.sanchez@gmail.com>
Copy link
Contributor

@dpordomingo dpordomingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Many thanks!!

@carlosms carlosms merged commit 9891f25 into src-d:master Apr 19, 2019
@carlosms carlosms deleted the sdk-analyzer-name branch April 19, 2019 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants