Skip to content

Remove merge field from review event #83

@smacker

Description

@smacker

This field is very confusing when you study proto files and the current behavior of this field bound to GitHub. Other providers have a similar field but with the different meaning. It contains sha of merge commit ONLY AFTER pull request is merged. Before it's empty.

According to discussions we don't need this field (at least for the first version of the service/analyzers) because we don't need to comment on closed pull requests.

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions