Skip to content

add ToStruct method to go sdk #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2018
Merged

add ToStruct method to go sdk #33

merged 1 commit into from
Nov 23, 2018

Conversation

smacker
Copy link
Contributor

@smacker smacker commented Nov 23, 2018

move ToStruct methods from lookout to sdk.

It's easy to work with protobuf structs in other languages, for example python. But a lot of pain in go.

Analyzers need this method for unit testing.

@smacker
add ToStruct method to go sdk
6b6c605 
Signed-off-by: Maxim Sukharev <max@smacker.ru>
carlosms
carlosms approved these changes Nov 23, 2018
View reviewed changes
Copy link
Contributor

@carlosms carlosms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Is there a reason for it to be ToPBStruct in lookout and ToStruct here?

@smacker
Copy link
Contributor Author

smacker commented Nov 23, 2018

package name

@smacker smacker merged commit 29b8d66 into src-d:master Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpordomingo dpordomingo Awaiting requested review from dpordomingo

1 more reviewer

@carlosms carlosms carlosms approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smacker @carlosms