Skip to content

Add method to access logger Fields #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add method to access logger Fields #9

wants to merge 1 commit into from

Conversation

carlosms
Copy link

@carlosms carlosms commented Nov 19, 2018 •
edited
Loading

@carlosms
Add method to access logger Fields
768b47c 
Signed-off-by: Carlos Martín <carlos.martin.sanchez@gmail.com>
@carlosms carlosms mentioned this pull request Nov 19, 2018
Merged
@carlosms
Copy link
Author

ping @mcuadros for review

@carlosms
Copy link
Author

carlosms commented Dec 3, 2018

friendly ping @mcuadros

@carlosms carlosms mentioned this pull request Dec 3, 2018
Merged
@carlosms
Copy link
Author

ping @mcuadros.

@mcuadros
Copy link
Contributor

mcuadros commented Dec 20, 2018 •
edited
Loading

As I spoke in person, the Logger shouldn't be used as a context dictionary, for this, you should use the context itself.

@mcuadros mcuadros closed this Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@kuba-- kuba-- kuba-- approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlosms @mcuadros @kuba--