Skip to content

Conversation

k0vah1911pepsi
Copy link
Contributor

Priority*

  • High: This PR needs to be merged first, before other tasks.
  • Medium: This PR should be merged quickly to prevent conflicts due to common changes. (default)
  • Low: This PR does not affect other tasks, so it can be merged later.

Purpose of the PR*

This PR updates and fixes selectors for the Gemini submit button and AiStudio chat input to ensure correct element detection and improve robustness

Changes*

Gemini Submit Button Selector:

Removed an unnecessary aria-label attribute from the selector for the submit button. This enhances selector specificity and improves robustness across different languages or when aria-label values might change or be absent.

AiStudio Chat Input Selectors:

Updated the selectors used to identify the chat input field to align with recent modifications in the page's HTML structure. The previous selectors were no longer effective due to these markup changes, leading to a failure in detecting the input field.

How to check the feature

  • Verify that the extension's interactions with the Gemini submit button are functioning as expected.
  • Verify that the extension's interactions with the AiStudio chat input field are functioning as expected (this should fix a previous detection issue)."

Reference

- Removed unnecessary `aria-label` from the Gemini submit button selector to improve specificity and multilingual support
- Adapted AiStudio chat input selectors to reflect recent markup changes that broke input detection
@k0vah1911pepsi k0vah1911pepsi requested a review from srbhptl39 as a code owner May 14, 2025 05:16
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. We will check and reply to you as soon as possible.

Copy link
Owner

@srbhptl39 srbhptl39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @k0vah1911pepsi, Changes look great, and works with latest aistudio and gemini.

@srbhptl39 srbhptl39 merged commit 404712a into srbhptl39:main May 14, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants