fix: prevent duplicate tool execution listeners for adapters #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a registration tracking mechanism to prevent the same adapter from registering multiple tool execution listeners. This fixes potential issues where duplicate event handlers could be created, leading to: - Multiple insertions of the same tool execution results - Increased memory usage from redundant event listeners - Possible race conditions in the tool execution workflow The fix uses a Set to track which adapters have already registered listeners and skips registration if an adapter attempts to register more than once. Fixes srbhptl39#21
|
Thanks @hayeah for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a registration tracking mechanism to prevent the same adapter from registering multiple tool execution listeners. This fixes potential issues where duplicate event handlers could be created.
Changes
Fixes
Fixes #21
Testing
Tested with multiple adapters to ensure: