Run tests on each major JDK version #3713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only need to build on a single JDK (the latest, 18) and target the lowest supported (8).
JakeWharton
commented
Mar 28, 2022
| @@ -26,3 +26,26 @@ jar { | |||
| attributes 'Automatic-Module-Name': 'retrofit2' | |||
| } | |||
| } | |||
|
|
|||
| // Create a test task for each supported JDK. | |||
| (8..17).each { majorVersion -> | |||
There was a problem hiding this comment.
18 hasn't been deployed by Adoptium yet, but the 18 on the CI runner will be used by the normal 'test' task.
JakeWharton
commented
Mar 28, 2022
Comment on lines
+32
to
+33
| // Adoptium JDK 9 cannot extract on Linux or Mac OS. | ||
| if (majorVersion == 9) return |
There was a problem hiding this comment.
I think this is a Gradle bug, but I'm not sure. I don't really care since it's only one really old JDK.
5 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only need to build on a single JDK (the latest, 18) and target the lowest supported (8).