New API, inMemorySocketPair() #1638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm using Array<Socket> instead of Pair<Socket, Socket> because Array is _slightly_ more friendly to Java-language consumers.
swankjesse
commented
Jun 12, 2025
| import okio.Socket | ||
| import okio.Source | ||
|
|
||
| internal class PipeSocket(val sinkPipe: Pipe, val sourcePipe: Pipe) : Socket { |
There was a problem hiding this comment.
Is this the right name? InMemorySocket might better fit the public API?
There was a problem hiding this comment.
Is it intended to be public in the future?
There was a problem hiding this comment.
Nope, not public. But the name will show up in toString() etc.
swankjesse
commented
Jun 12, 2025
| /** Returns a pair of mutually-connected sockets. */ | ||
| abstract fun createSocketPair(): Pair<Socket, Socket> | ||
| /** Returns two mutually-connected sockets. */ | ||
| abstract fun createSocketPair(): Array<Socket> |
There was a problem hiding this comment.
I checked our API dump and there’s very little we’re exporting from the kotlin stdlib in Okio’s API. The only one I saw was Options and TypedOptions both expose kotlin.collections.AbstractList as their supertype, instead of java.util.AbstractList.
JakeWharton
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using Array instead of Pair<Socket, Socket> because Array is slightly more friendly to Java-language consumers.