Don't use Clock.System on an JVM release #1648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Okio was broken when running on Kotlin before 2.1.20.
The failure mode was too severe - a crash at runtime!
And this is for code that worked just fine on Kotlin 2.0.x.
java.lang.NoSuchMethodError: 'kotlin.time.Clock kotlin.internal.PlatformImplementations.getSystemClock()'
at kotlin.time.InstantJvmKt.<clinit>(InstantJvm.kt:12)
at kotlin.time.Clock$System.now(Clock.kt:60)
at kotlinx.datetime.Clock$System.now(DeprecatedClock.kt:89)
at okio.fakefilesystem.-Time.defaultClockNowMillis_delegate$lambda$2(FileMetadataCommon.kt:70)
at kotlin.SynchronizedLazyImpl.getValue(LazyJVM.kt:74)
at okio.fakefilesystem.-Time.getDefaultClockNowMillis(FileMetadataCommon.kt:65)
at okio.fakefilesystem.FakeFileSystem.<init>(FakeFileSystem.kt:72)
The failure would occur anywhere we were running Okio's
FakeFileSystem inside a Gradle plugin.
With this change FakeFileSystem works inside a Gradle plugin,
even if the runtime Kotlin version doesn't have
kotlin.time.Clock.
colinrtwhite
approved these changes
Jul 1, 2025
oldergod
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okio was broken when running on Kotlin before 2.1.20. The failure mode was too severe - a crash at runtime! And this is for code that worked just fine on Kotlin 2.0.x.
The failure would occur anywhere we were running Okio's FakeFileSystem inside a Gradle plugin.
With this change FakeFileSystem works inside a Gradle plugin, even if the runtime Kotlin version doesn't have
kotlin.time.Clock.