Don't crash when running on Kotlin before 2.1.20+ #1647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0600a43 to
1231947
Compare
This crash impacts people using FakeFileSystem in code that runs in a Gradle plugin.
1231947 to
dd4c01b
Compare
swankjesse
commented
Jun 30, 2025
| public fun <init> ()V | ||
| public fun <init> (Lkotlin/time/Clock;)V | ||
| public synthetic fun <init> (Lkotlin/time/Clock;ILkotlin/jvm/internal/DefaultConstructorMarker;)V | ||
| public synthetic fun <init> (Lkotlinx/datetime/Clock;)V | ||
| public synthetic fun <init> (Lkotlinx/datetime/Clock;ILkotlin/jvm/internal/DefaultConstructorMarker;)V |
There was a problem hiding this comment.
This is the function I very much want to restore.
There was a problem hiding this comment.
Without it, lots of downstream tests fail like this:
java.lang.NoSuchMethodError: 'void okio.fakefilesystem.FakeFileSystem.<init>(kotlinx.datetime.Clock, int, kotlin.jvm.internal.DefaultConstructorMarker)'
at com.squareup.wire.SchemaBuilder.<init>(SchemaBuilder.kt:32)
at app.cash.api.ProguardRulesGeneratorTest.stuff(ProguardRulesGeneratorTest.kt:68)
```
swankjesse
commented
Jun 30, 2025
| @@ -1,8 +1,9 @@ | |||
| public final class okio/fakefilesystem/FakeFileSystem : okio/FileSystem { | |||
| public final field clock Lkotlin/time/Clock; | |||
There was a problem hiding this comment.
I can’t have this field and maintain compatibility with Gradle 8.x.
swankjesse
commented
Jun 30, 2025
| @@ -20,6 +21,7 @@ public final class okio/fakefilesystem/FakeFileSystem : okio/FileSystem { | |||
| public final fun getAllowReadsWhileWriting ()Z | |||
| public final fun getAllowSymlinks ()Z | |||
| public final fun getAllowWritesWhileWriting ()Z | |||
| public final fun getClock ()Lkotlin/time/Clock; | |||
There was a problem hiding this comment.
...But this property should be fine.
swankjesse
commented
Jun 30, 2025
| @@ -18,7 +18,7 @@ jmh-gradle-plugin = { module = "me.champeau.jmh:jmh-gradle-plugin", version = "0 | |||
| kotlin-gradle-plugin = { module = "org.jetbrains.kotlin:kotlin-gradle-plugin", version.ref = "kotlin" } | |||
| kotlin-test = { module = "org.jetbrains.kotlin:kotlin-test" } | |||
| kotlin-test-junit = { module = "org.jetbrains.kotlin:kotlin-test-junit" } | |||
| kotlin-time = { module = "org.jetbrains.kotlinx:kotlinx-datetime", version = "0.7.0" } | |||
| kotlin-time = { module = "org.jetbrains.kotlinx:kotlinx-datetime", version = "0.7.0-0.6.x-compat" } | |||
There was a problem hiding this comment.
This compat version is a nice bridge
oldergod
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This crash impacts people using FakeFileSystem in code that runs in a Gradle plugin.