Postgres: Add IS JSON syntax support #7001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Summary
Added support for PostgreSQL 16's IS JSON syntax validation according to SQL/JSON standard, enabling parsing of expressions like SELECT '{}' IS JSON.
- Added grammar rules in
src/sqlfluff/dialects/dialect_postgres.pyto supportIS JSONclauses with type specifications (VALUE, SCALAR, ARRAY, OBJECT) - Added new non-reserved keywords 'KEYS' and 'SCALAR' in
src/sqlfluff/dialects/dialect_postgres_keywords.py - Created comprehensive test suite in
test/fixtures/dialects/postgres/is_json.sqlandis_json.ymlcovering various JSON validation scenarios - Extended IsClauseGrammar while maintaining backward compatibility with existing IS clause parsing
4 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
| @@ -954,6 +954,7 @@ def get_keywords(keyword_list: list[tuple[str, str]], keyword_type: str) -> list | |||
| ("INDEX_CLEANUP", "non-reserved"), | |||
| ("IS_TEMPLATE", "non-reserved"), | |||
| ("JSON", "non-reserved"), | |||
| ("KEYS", "non-reserved"), | |||
There was a problem hiding this comment.
style: Consider ordering keywords alphabetically within the list for consistency with surrounding entries
Coverage Results ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
Fixes #7000.
This PR implements support for PostgreSQL 16's
IS JSONsyntax validation as defined in the SQL/JSON standard. Previously, expressions likeSELECT '{}' IS JSON;resulted in "Found unparsable section" errors.Fixes the reported parsing issue where PostgreSQL
IS JSONexpressions were unparsable.Are there any other side effects of this change that we should be aware of?
IsClauseGrammarwhich could potentially affect other IS-clause parsing, but this is backwards compatible.Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.ymlrule test cases intest/fixtures/rules/std_rule_cases..sql/.ymlparser test cases intest/fixtures/dialects(note YML files can be auto generated withtox -e generate-fixture-yml).test/fixtures/linter/autofix.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.