Skip to content

LT14: Add exclusion configuration option #6909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 3, 2025
Merged

LT14: Add exclusion configuration option #6909

merged 3 commits into from
Jun 3, 2025

Conversation

keraion
Copy link
Contributor

@keraion keraion commented May 21, 2025

Brief summary of the change made

This allows LT14 to exclude changing the keyword line layout of a type of keyword when they exist as a descendent of another type.

This also removes ALLOWABLE_LAYOUT_CONFIG_KEYS which was unused in config/loader.py

Are there any other side effects of this change that we should be aware of?

None, but it might be worth adding some defaults to this.

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 21, 2025 •
edited
Loading

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   19703      0   100%

249 files skipped due to complete coverage.

WittierDinosaur
WittierDinosaur requested changes May 21, 2025
View reviewed changes
Copy link
Contributor

@WittierDinosaur WittierDinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic! I think for the order by/ window spec combo it should go into the default config. I've deployed this update at my company, and I've yet to find anyone who prefers the current newline behaviour for order by in window specs

@keraion
Copy link
Contributor Author

keraion commented May 22, 2025

I went ahead and defaulted the ones that existed in the two issues: window_specification, aggregate_order_by, and withingroup_clause. The window_specification was the most requested and the other two should be smaller clauses anyways.

WittierDinosaur
WittierDinosaur approved these changes Jun 3, 2025
View reviewed changes
Copy link
Contributor

@WittierDinosaur WittierDinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WittierDinosaur WittierDinosaur added this pull request to the merge queue Jun 3, 2025
Merged via the queue into main with commit f7c263f Jun 3, 2025
30 checks passed
@WittierDinosaur WittierDinosaur deleted the LT14_ignore_inside_parent branch June 3, 2025 15:39
thomascjohnson pushed a commit to thomascjohnson/sqlfluff that referenced this pull request Jun 17, 2025
@keraion @thomascjohnson
LT14: Add exclusion configuration option (sqlfluff#6909)
d995e8b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WittierDinosaur WittierDinosaur WittierDinosaur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@keraion @WittierDinosaur