Skip to content

CLI: Read inline configurations when using --stdin-filename #6900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 3, 2025
Merged

CLI: Read inline configurations when using --stdin-filename #6900

merged 2 commits into from
Jun 3, 2025

Conversation

keraion
Copy link
Contributor

@keraion keraion commented May 18, 2025

Brief summary of the change made

When passing --stdin-filename sqlfluff will assume that a dialect is required to be specified. This changes allows for a dialect to be specified within stdin contents without one being specified inside a configuration file for that location.

Are there any other side effects of this change that we should be aware of?

None

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 18, 2025 •
edited
Loading

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   19693      0   100%

249 files skipped due to complete coverage.

alanmcruickshank
alanmcruickshank approved these changes Jun 3, 2025
View reviewed changes
Copy link
Member

@alanmcruickshank alanmcruickshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alanmcruickshank alanmcruickshank added this pull request to the merge queue Jun 3, 2025
Merged via the queue into main with commit 0990f87 Jun 3, 2025
30 checks passed
@alanmcruickshank alanmcruickshank deleted the inline_dialect_with_stdin_filename branch June 3, 2025 15:52
thomascjohnson pushed a commit to thomascjohnson/sqlfluff that referenced this pull request Jun 17, 2025
@keraion @alanmcruickshank @thomascjohnson
CLI: Read inline configurations when using --stdin-filename (sqlflu…
55eb6e6 
…ff#6900)

Co-authored-by: Alan Cruickshank <alanmcruickshank@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanmcruickshank alanmcruickshank alanmcruickshank approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Are there In-File Configuration Directives for dialect?
2 participants
@keraion @alanmcruickshank