feat(databricks): add support for single-line magics #6999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Summary
Enhanced the Databricks dialect to support single-line magic commands by adding new lexer and grammar rules.
- Added support for single-line magic commands (e.g.,
-- MAGIC %run ./Notebook) insrc/sqlfluff/dialects/dialect_databricks.py - Created new test fixture
test/fixtures/dialects/databricks/magic_single_line.sqldemonstrating both multi-line and single-line magic command usage - Added corresponding YAML test fixtures in
test/fixtures/dialects/databricks/magic_single_line.ymlto validate parsing behavior - Implementation maintains compatibility with existing magic cell functionality while adding distinct segment type for single-line commands
3 files reviewed, 2 comments
Edit PR Review Bot Settings | Greptile
Coverage Results ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
This PR adds support for Databricks single-line magics (e.g.,
-- MAGIC %run ./Notebook) to the Databricks dialect.magic_single_lineregex lexer and grammar to correctly parse single-line magics as their own segment type.MagicCellStatementSegmentto allow either multi-line or single-line magics.fixes #6998
Are there any other side effects of this change that we should be aware of?
No known side effects. This change is isolated to the Databricks dialect and only affects parsing of magic lines.
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.ymlrule test cases intest/fixtures/rules/std_rule_cases..sql/.ymlparser test cases intest/fixtures/dialects(note YML files can be auto generated withtox -e generate-fixture-yml).test/fixtures/linter/autofix.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.