Trino: support ALTER TABLE #6996

ykicisk · 2025-07-09T04:34:51Z

Brief summary of the change made

Added support for

ALTER TABLE statement
NOT NULL in CREATE TABLE statement.
- ref: https://trino.io/docs/current/sql/create-table.html

Are there any other side effects of this change that we should be aware of?

No

Pull Request checklist

Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
- .yml rule test cases in test/fixtures/rules/std_rule_cases.
- .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
- Full autofix test cases in test/fixtures/linter/autofix.
- Other.
Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.

github-actions · 2025-07-09T04:44:50Z

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   19870      0   100%

253 files skipped due to complete coverage.

greptile-apps

PR Summary

Added comprehensive support for Trino dialect's ALTER TABLE statements and NOT NULL constraints in CREATE TABLE statements, with complete test coverage.

Extended src/sqlfluff/dialects/dialect_trino.py to implement ALTER TABLE operations (rename, add/drop columns, set properties)
Added new lexer and parser support for execute arrow ('=>') operator in dialect_trino.py
Created test/fixtures/dialects/trino/alter_table.sql with extensive test cases for all ALTER TABLE variations
Enhanced test/fixtures/dialects/trino/create_table.sql to include NOT NULL constraint testing
Added comprehensive test coverage in corresponding YAML files for all new syntax features

_{5 files reviewed, 5 comments}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2025-07-09T09:47:00Z

test/fixtures/dialects/trino/create_table.yml

+      - column_definition:
+        - naked_identifier: shipmentstatus
+        - data_type:
+            keyword: varchar
+        - keyword: not
+        - keyword: 'null'
+      - comma: ','


style: Inconsistent indentation in column definition compared to other similar blocks in this file. Other column definitions use double indentation.

greptile-apps · 2025-07-09T09:47:00Z

test/fixtures/dialects/trino/create_table.yml

+        - keyword: not
+        - keyword: 'null'


style: Keep NOT NULL case consistent with other keywords in file (uppercase).

greptile-apps · 2025-07-09T09:47:02Z

test/fixtures/dialects/trino/alter_table.sql

+ALTER TABLE t1 SET PROPERTIES x = 'y';
+ALTER TABLE t1 SET PROPERTIES foo = 123, bar = 456;


style: Add test for setting property to DEFAULT value, which is a documented feature for reverting properties to default values

I have addressed it in these commits.
ec39758...992ab05

greptile-apps · 2025-07-09T09:47:02Z

src/sqlfluff/dialects/dialect_trino.py

+                OneOf(
+                    Sequence(
+                        "SET",
+                        "DATA",
+                        "TYPE",
+                        Ref("DatatypeSegment"),
+                    ),
+                    Sequence(
+                        "DROP",
+                        "NOT",
+                        "NULL",
+                    ),
+                ),


logic: missing support for 'SET NOT NULL' in ALTER COLUMN

Suggested change

OneOf(

Sequence(

"SET",

"DATA",

"TYPE",

Ref("DatatypeSegment"),

),

Sequence(

"DROP",

"NOT",

"NULL",

),

),

OneOf(

Sequence(

"SET",

"DATA",

"TYPE",

Ref("DatatypeSegment"),

),

Sequence(

"SET",

"NOT",

"NULL"

),

Sequence(

"DROP",

"NOT",

"NULL",

),

),

Trino's ALTER TABLE statement does not support the SET NOT NULL syntax.
https://trino.io/docs/current/sql/alter-table.html

greptile-apps · 2025-07-09T09:47:04Z

src/sqlfluff/dialects/dialect_trino.py

+    match_grammar = Sequence(
+        "ALTER",
+        "TABLE",
+        Ref("IfExistsGrammar", optional=True),
+        Ref("TableReferenceSegment"),


style: no support for 'ALTER TABLE ... COMMENT ON COLUMN' operation

Trino's ALTER TABLE statement does not support the COMMENT ON COLUMN syntax.
https://trino.io/docs/current/sql/alter-table.html

keraion · 2025-07-09T12:26:59Z

src/sqlfluff/dialects/dialect_trino.py

+                        "SET",
+                        "DATA",
+                        "TYPE",
+                        Ref("DatatypeSegment"),


Does this need to support datatypes with brackets like in ColumnDefinitionSegment?

Bracketed(Anything(), optional=True), # For types like VARCHAR(100)

@keraion
Thank you for your feedback!

DatatypeSegment already supports syntax like VARCHAR(100).

sqlfluff/src/sqlfluff/dialects/dialect_trino.py

Lines 309 to 313 in 74aaf39

# String

Sequence(

OneOf("CHAR", "VARCHAR"),

Ref("BracketedArguments", optional=True),

),

I fixed ColumnDefinitionSegment and added the test.
df6bbc4

… for ALTER COLUMN

keraion

LGTM. Thanks!

Trino: support ALTER TABLE

221e0de

ykicisk and others added 2 commits July 9, 2025 13:50

linting

ec01475

Merge branch 'main' into trino-alter-table

ec39758

ykicisk marked this pull request as ready for review July 9, 2025 09:46

greptile-apps bot reviewed Jul 9, 2025

View reviewed changes

ykicisk added 2 commits July 9, 2025 18:53

add test for setting property to DEFAULT value

e83281c

add test for setting property to DEFAULT value

992ab05

keraion reviewed Jul 9, 2025

View reviewed changes

remove optional bracket from ColumnDefinitionSegment and update tests…

df6bbc4

… for ALTER COLUMN

keraion approved these changes Jul 10, 2025

View reviewed changes

keraion added this pull request to the merge queue Jul 10, 2025

Merged via the queue into sqlfluff:main with commit 07db73d Jul 10, 2025
28 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Trino: support ALTER TABLE #6996

Trino: support ALTER TABLE #6996

Uh oh!

ykicisk commented Jul 9, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 9, 2025 •

edited

Loading

Uh oh!

greptile-apps bot left a comment

Uh oh!

greptile-apps bot Jul 9, 2025

Uh oh!

greptile-apps bot Jul 9, 2025

Uh oh!

greptile-apps bot Jul 9, 2025

Uh oh!

ykicisk Jul 9, 2025

Uh oh!

greptile-apps bot Jul 9, 2025

Uh oh!

ykicisk Jul 9, 2025

Uh oh!

greptile-apps bot Jul 9, 2025

Uh oh!

ykicisk Jul 9, 2025

Uh oh!

keraion Jul 9, 2025

Uh oh!

ykicisk Jul 10, 2025 •

edited

Loading

Uh oh!

keraion left a comment

Uh oh!

Uh oh!

Uh oh!

		ALTER TABLE t1 SET PROPERTIES x = 'y';
		ALTER TABLE t1 SET PROPERTIES foo = 123, bar = 456;

	# String
	Sequence(
	OneOf("CHAR", "VARCHAR"),
	Ref("BracketedArguments", optional=True),
	),

Uh oh!

Trino: support ALTER TABLE #6996

Trino: support ALTER TABLE #6996

Uh oh!

Conversation

ykicisk commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Brief summary of the change made

Are there any other side effects of this change that we should be aware of?

Pull Request checklist

Uh oh!

github-actions bot commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Results ✅

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

Uh oh!

greptile-apps bot Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

ykicisk Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

ykicisk Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

ykicisk Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

keraion Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

ykicisk Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

keraion left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ykicisk commented Jul 9, 2025 •

edited

Loading

github-actions bot commented Jul 9, 2025 •

edited

Loading

ykicisk Jul 10, 2025 •

edited

Loading