Skip to content

CV12 and AL05: Prevent AL05 from deleting rewritten CV12 references #6981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 1, 2025
Merged

CV12 and AL05: Prevent AL05 from deleting rewritten CV12 references #6981

merged 2 commits into from
Jul 1, 2025

Conversation

keraion
Copy link
Contributor

@keraion keraion commented Jul 1, 2025

Brief summary of the change made

This stops AL05 from deleting references that may have been moved around from the where_clause into the join_on_condition.

Are there any other side effects of this change that we should be aware of?

None

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

greptile-apps[bot]
greptile-apps bot reviewed Jul 1, 2025
View reviewed changes
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Fixed interaction between rules CV12 and AL05 where table aliases were being incorrectly deleted after moving WHERE conditions to JOIN ON clauses.

  • Modified src/sqlfluff/rules/convention/CV12.py to properly construct JoinOnConditionSegment and JoinClauseSegment objects when moving conditions
  • Added test/fixtures/rules/std_rule_cases/AL05_CV12.yml with test cases for alias preservation in LEFT JOIN scenarios
  • Updated src/sqlfluff/utils/testing/rules.py to handle comma-separated rule names in test IDs by replacing commas with underscores

3 files reviewed, no comments
Edit PR Review Bot Settings | Greptile

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 1, 2025

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   19774      0   100%

249 files skipped due to complete coverage.

WittierDinosaur
WittierDinosaur approved these changes Jul 1, 2025
View reviewed changes
Copy link
Contributor

@WittierDinosaur WittierDinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WittierDinosaur WittierDinosaur added this pull request to the merge queue Jul 1, 2025
Merged via the queue into main with commit 1bd8595 Jul 1, 2025
30 checks passed
@WittierDinosaur WittierDinosaur deleted the CV12_AL05_conflict branch July 1, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WittierDinosaur WittierDinosaur WittierDinosaur approved these changes

+1 more reviewer

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule CV12 deletes alias from table where columns are absent from the select statement
2 participants
@keraion @WittierDinosaur