DuckDB: add support for additional star expressions #6977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Summary
Enhanced DuckDB dialect support by implementing additional star expression syntax including * RENAME, pattern matching operators, and *COLUMNS unpacking features.
- Added support for DuckDB's pattern matching operators (
LIKE,ILIKE,GLOB,~~~) insrc/sqlfluff/dialects/dialect_duckdb.py - Extracted and standardized
LikeExpressionGrammarinsrc/sqlfluff/dialects/dialect_ansi.pyfor better code reuse - Added comprehensive test coverage in
test/fixtures/dialects/duckdb/star_expression.sqlfor new star expression features - Simplified LIKE expression handling in
src/sqlfluff/dialects/dialect_vertica.pyby using the new grammar component - Added glob operator lexer matcher
~~~to support DuckDB's pattern matching expressions
5 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
Coverage Results ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
This adds support for the
* RENAME,* [pattern_matching], and*COLUMNSunpacking operatorsAre there any other side effects of this change that we should be aware of?
none
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.ymlrule test cases intest/fixtures/rules/std_rule_cases..sql/.ymlparser test cases intest/fixtures/dialects(note YML files can be auto generated withtox -e generate-fixture-yml).test/fixtures/linter/autofix.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.