Adds support for json_object syntax in Oracle.
#6973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Summary
Adds support for Oracle's JSON_OBJECT function with both modern colon separator syntax (Oracle 19c+) and legacy VALUE keyword format.
- Added new grammar rules in
src/sqlfluff/dialects/dialect_oracle.pyfor JSON object content, entries, and null handling - Created test file
test/fixtures/dialects/oracle/json_object.sqlcovering various syntax scenarios (KEY/VALUE keywords, wildcards, format options) - Added corresponding YAML test definitions in
test/fixtures/dialects/oracle/json_object.ymlfor syntax validation - Implementation matches official Oracle documentation examples and maintains backward compatibility
3 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
| SELECT JSON_ARRAYAGG(JSON_OBJECT(*)) | ||
| FROM departments; | ||
|
|
||
| SELECT JSON_OBJECT ('name' value 'Foo') FROM DUAL; |
There was a problem hiding this comment.
style: 'value' keyword is lowercase here but uppercase in other examples - should be consistent throughout tests
Coverage Results ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6966
Test examples from Oracle docs
Brief summary of the change made
Are there any other side effects of this change that we should be aware of?
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.ymlrule test cases intest/fixtures/rules/std_rule_cases..sql/.ymlparser test cases intest/fixtures/dialects(note YML files can be auto generated withtox -e generate-fixture-yml).test/fixtures/linter/autofix.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.