SQLite: Make ACTION a non-reserved keyword
#6970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Summary
Makes ACTION a non-reserved keyword in SQLite dialect, allowing its use as an identifier (e.g., column name) while maintaining keyword recognition in appropriate contexts.
- Moved
ACTIONfromRESERVED_KEYWORDStoUNRESERVED_KEYWORDSinsrc/sqlfluff/dialects/dialect_sqlite_keywords.py - Added test cases in
test/fixtures/dialects/sqlite/create_trigger.sqldemonstrating valid usage ofactionas a column name - Fixed issue #6965 where SQLFluff couldn't parse valid SQLite trigger statements with
actioncolumns - Change aligns with SQLite's official behavior where
ACTIONis not a reserved keyword
3 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
| @@ -205,4 +204,5 @@ | |||
| "NOCASE", | |||
| "RTRIM", | |||
| "STORED", # https://sqlite.org/forum/forumpost/91127ba3db | |||
| "ACTION", | |||
There was a problem hiding this comment.
style: Add a comment linking to SQLite docs or the issue for why ACTION was moved to unreserved, similar to the STORED keyword comment
Coverage Results ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
Changes the keyword
ACTIONfrom reserved to non-reserved.Are there any other side effects of this change that we should be aware of?
None
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.ymlrule test cases intest/fixtures/rules/std_rule_cases..sql/.ymlparser test cases intest/fixtures/dialects(note YML files can be auto generated withtox -e generate-fixture-yml).test/fixtures/linter/autofix.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.