Skip to content

Snowflake: fix collate grammar with aliases #6967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2025
Merged

Snowflake: fix collate grammar with aliases #6967

merged 1 commit into from
Jul 1, 2025

Conversation

keraion
Copy link
Contributor

@keraion keraion commented Jun 24, 2025

Brief summary of the change made

This fixes CREATE TABLE statements that have COLLATE and aliases specified.

Are there any other side effects of this change that we should be aware of?

None

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

greptile-apps[bot]
greptile-apps bot reviewed Jun 24, 2025
View reviewed changes
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Enhanced Snowflake dialect support by fixing COLLATE grammar with column aliasing in CREATE TABLE statements.

  • Modified src/sqlfluff/dialects/dialect_snowflake.py to add CollateGrammar pattern for proper parsing of COLLATE statements
  • Added test case in test/fixtures/dialects/snowflake/create_table.sql to validate COLLATE with column aliasing
  • Fixed parsing errors in CREATE TABLE AS SELECT statements when using COLLATE infix notation with aliases

3 files reviewed, no comments
Edit PR Review Bot Settings | Greptile

@github-actions GitHub Actions
Copy link
Contributor

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   19770      0   100%

249 files skipped due to complete coverage.

WittierDinosaur
WittierDinosaur approved these changes Jul 1, 2025
View reviewed changes
Copy link
Contributor

@WittierDinosaur WittierDinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WittierDinosaur WittierDinosaur added this pull request to the merge queue Jul 1, 2025
Merged via the queue into main with commit 49bfec1 Jul 1, 2025
30 checks passed
@WittierDinosaur WittierDinosaur deleted the snowflake_collate branch July 1, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WittierDinosaur WittierDinosaur WittierDinosaur approved these changes

+1 more reviewer

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Snowflake - COLLATE infix notation results in parser error
2 participants
@keraion @WittierDinosaur