TSQL: Rework the execute statement block to latest specs #6953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Summary
Major overhaul of TSQL EXECUTE statement grammar to align with Microsoft's latest specifications, improving parsing accuracy and feature coverage.
- Updated
src/sqlfluff/dialects/dialect_tsql.pywith comprehensive EXECUTE statement grammar including RESULT SETS, OUTPUT parameters, and execution context options - Moved 'THROW' from UNRESERVED to RESERVED keywords list in
src/sqlfluff/dialects/dialect_tsql_keywords.py - Added proper expression node handling for parameter values across multiple test files including
test/fixtures/dialects/tsql/execute.yml - Expanded test coverage with official Microsoft documentation examples in
test/fixtures/dialects/tsql/execute.sql
8 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
Coverage Results ✅ |
WittierDinosaur
requested changes
Jun 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
This PR reworks the EXECUTE statement grammar to the latest full specification. Also added all tests from the specification to our test set.
Note:
THROWkeyword has been moved to the reserved keyword list.Fixes #6489
Are there any other side effects of this change that we should be aware of?
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.ymlrule test cases intest/fixtures/rules/std_rule_cases..sql/.ymlparser test cases intest/fixtures/dialects(note YML files can be auto generated withtox -e generate-fixture-yml).test/fixtures/linter/autofix.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.