TSQL: Add support for CREATE TABLE GRAPH statements #6948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add required keywords * Add graph table syntax variation with AS NODE and AS EDGE reusing as much as possible * Add related constraints
There was a problem hiding this comment.
PR Summary
Added support for Microsoft SQL Server's graph table feature in the TSQL dialect, enabling parsing of CREATE TABLE statements with graph-specific syntax and constraints.
- Added graph table keywords ('CONNECTION', 'EDGE', 'NODE') in
src/sqlfluff/dialects/dialect_tsql_keywords.py - Implemented
ConnectionConstraintGrammarandGraphTableConstraintSegmentinsrc/sqlfluff/dialects/dialect_tsql.pyfor graph relationships - Added
CreateTableGraphStatementSegmentto support 'AS NODE' and 'AS EDGE' table declarations - Created comprehensive test cases in
test/fixtures/dialects/tsql/create_table_graph.sqlcovering various graph table scenarios
4 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
keraion
reviewed
Jun 17, 2025
Coverage Results ✅ |
keraion
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
This PR is adding support for graph tables in TSQL. These use special syntax at table creation and a specific constraint for such tables.
PS: My first contribution to this repo, happy to take advice on further improvements in this PR.
Are there any other side effects of this change that we should be aware of?
No
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.ymlrule test cases intest/fixtures/rules/std_rule_cases..sql/.ymlparser test cases intest/fixtures/dialects(note YML files can be auto generated withtox -e generate-fixture-yml).test/fixtures/linter/autofix.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.