Skip to content

CV12: fix assertion on bracketed join #6898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 17, 2025
Merged

CV12: fix assertion on bracketed join #6898

merged 2 commits into from
May 17, 2025

Conversation

keraion
Copy link
Contributor

@keraion keraion commented May 16, 2025

Brief summary of the change made

This handles the case where multiple from_expression_elements may exist when looking for joins.

Are there any other side effects of this change that we should be aware of?

None

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@github-actions GitHub Actions
Copy link
Contributor

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   19685      0   100%

249 files skipped due to complete coverage.

WittierDinosaur
WittierDinosaur approved these changes May 17, 2025
View reviewed changes
Copy link
Contributor

@WittierDinosaur WittierDinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WittierDinosaur WittierDinosaur added this pull request to the merge queue May 17, 2025
Merged via the queue into main with commit 7d3e4ef May 17, 2025
30 checks passed
@WittierDinosaur WittierDinosaur deleted the cv12_fix_bracketed_join branch May 17, 2025 14:35
thomascjohnson pushed a commit to thomascjohnson/sqlfluff that referenced this pull request Jun 17, 2025
@keraion @thomascjohnson
CV12: fix assertion on bracketed join (sqlfluff#6898)
fab408c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WittierDinosaur WittierDinosaur WittierDinosaur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CV12 convention.join_condition AssertionError
2 participants
@keraion @WittierDinosaur