Skip to content

Adds support for variadic declarations in Postgres. #6887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 16, 2025
Merged

Adds support for variadic declarations in Postgres. #6887

merged 3 commits into from
May 16, 2025

Conversation

joaostorrer
Copy link
Contributor

@joaostorrer joaostorrer commented May 12, 2025 •
edited by keraion
Loading

Examples taken from https://www.postgresql.org/docs/17/xfunc-sql.html

Makes progress on #6784

Brief summary of the change made

Are there any other side effects of this change that we should be aware of?

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@github-actions GitHub Actions
Copy link
Contributor

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   19687      0   100%

249 files skipped due to complete coverage.

keraion
keraion approved these changes May 16, 2025
View reviewed changes
Copy link
Contributor

@keraion keraion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is a good change, but I'm not sure it fully addresses the reproduction example in the linked issue.

That also being said I'm not finding much in the way of documentation of how the reproduction should be working.

@keraion keraion added this pull request to the merge queue May 16, 2025
Merged via the queue into sqlfluff:main with commit 5d5fe0a May 16, 2025
28 checks passed
@joaostorrer joaostorrer deleted the postgres_variadic branch June 4, 2025 17:53
@joaostorrer joaostorrer restored the postgres_variadic branch June 4, 2025 17:53
thomascjohnson pushed a commit to thomascjohnson/sqlfluff that referenced this pull request Jun 17, 2025
@joaostorrer @thomascjohnson
Adds support for variadic declarations in Postgres. (sqlfluff#6887)
b128982
@kha84 kha84 mentioned this pull request Jul 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keraion keraion keraion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joaostorrer @keraion