Skip to content

Add pgvector operators #6863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 4, 2025
Merged

Add pgvector operators #6863

merged 3 commits into from
May 4, 2025

Conversation

reteps
Copy link
Contributor

@reteps reteps commented May 4, 2025 •
edited
Loading

Brief summary of the change made

Supports pgvector operations

Are there any other side effects of this change that we should be aware of?

N/A

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@reteps reteps marked this pull request as ready for review May 4, 2025 05:04
@reteps reteps mentioned this pull request May 4, 2025
Open
WittierDinosaur
WittierDinosaur reviewed May 4, 2025
View reviewed changes
test/fixtures/dialects/postgres/postgres_pgvector_operators.sql Outdated

SELECT * FROM items ORDER BY embedding <+> '[3,1,2]' LIMIT 5;

SELECT * FROM items ORDER BY embedding <#> '[3,1,2]' LIMIT 5;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: newline

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved in 0e015ef.

@reteps reteps requested a review from WittierDinosaur May 4, 2025 16:43
WittierDinosaur
WittierDinosaur approved these changes May 4, 2025
View reviewed changes
Copy link
Contributor

@WittierDinosaur WittierDinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WittierDinosaur WittierDinosaur enabled auto-merge May 4, 2025 18:02
auto-merge was automatically disabled May 4, 2025 18:09

Head branch was pushed to by a user without write access

@reteps
Copy link
Contributor Author

reteps commented May 4, 2025

@WittierDinosaur can you approve? there was a lint error.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 4, 2025 •
edited
Loading

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   19637      0   100%

249 files skipped due to complete coverage.

@WittierDinosaur WittierDinosaur enabled auto-merge May 4, 2025 18:20
@WittierDinosaur WittierDinosaur added this pull request to the merge queue May 4, 2025
Merged via the queue into sqlfluff:main with commit fbfb3de May 4, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WittierDinosaur WittierDinosaur WittierDinosaur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reteps @WittierDinosaur