Skip to content

Fill in gap in parsing create user rsa_public_key=... / snowflake #6731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2025
Merged

Fill in gap in parsing create user rsa_public_key=... / snowflake #6731

merged 1 commit into from
Mar 22, 2025

Conversation

juli4nb4dillo
Copy link
Contributor

@juli4nb4dillo juli4nb4dillo commented Mar 14, 2025 •
edited
Loading

Brief summary of the change made

fixes #6712

Allow parsing of statements like:

CREATE USER user1
RSA_PUBLIC_KEY = '<PUBLIC RSA KEY IN BASE64>';

For the snowflake dialect: https://docs.snowflake.com/en/sql-reference/sql/create-user

Please review, I'll be happy to contribute to snowflake dialect.

@juli4nb4dillo juli4nb4dillo changed the title Fill in gap in parsing create user rsa_public_key=... to snowflake dialect Fill in gap in parsing create user rsa_public_key=... / snowflake Mar 14, 2025
WittierDinosaur
WittierDinosaur approved these changes Mar 22, 2025
View reviewed changes
Copy link
Contributor

@WittierDinosaur WittierDinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WittierDinosaur WittierDinosaur added this pull request to the merge queue Mar 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   19341      0   100%

248 files skipped due to complete coverage.

Merged via the queue into sqlfluff:main with commit 2fd4b0e Mar 22, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WittierDinosaur WittierDinosaur WittierDinosaur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gap in Snowflake CREATE USER ... RSA_PUBLIC_KEY = '...'
2 participants
@juli4nb4dillo @WittierDinosaur