Skip to content

BigQuery: support UNION ALL BY NAME and other new set operator modifiers #6722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2025
Merged

BigQuery: support UNION ALL BY NAME and other new set operator modifiers #6722

merged 1 commit into from
Mar 22, 2025

Conversation

Robin-C
Copy link
Contributor

@Robin-C Robin-C commented Mar 11, 2025 •
edited
Loading

Brief summary of the change made

This PR adds support for the recently released "union all by name" syntax in bigquery.

See https://cloud.google.com/bigquery/docs/reference/standard-sql/query-syntax#set_operators for more information

This PR should resolve #6643.

Are there any other side effects of this change that we should be aware of?

Not that I'm aware of

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@Robin-C Robin-C changed the title bigquery: support "union all by name" [WIP] bigquery: support "union all by name" Mar 12, 2025
@Robin-C Robin-C marked this pull request as draft March 12, 2025 14:48
@Robin-C Robin-C marked this pull request as ready for review March 12, 2025 21:04
@Robin-C Robin-C changed the title [WIP] bigquery: support "union all by name" bigquery: support "union all by name" Mar 12, 2025
@Robin-C Robin-C changed the title bigquery: support "union all by name" BigQuery: support UNION ALL BY NAME and other new set operator modifiers Mar 13, 2025
@Robin-C Robin-C force-pushed the main branch 3 times, most recently from 9f53dbd to ca3cbed Compare March 19, 2025 08:24
WittierDinosaur
WittierDinosaur approved these changes Mar 22, 2025
View reviewed changes
Copy link
Contributor

@WittierDinosaur WittierDinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WittierDinosaur WittierDinosaur added this pull request to the merge queue Mar 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   19344      0   100%

248 files skipped due to complete coverage.

Merged via the queue into sqlfluff:main with commit 2e5bd6c Mar 22, 2025
29 checks passed
@keraion keraion mentioned this pull request Mar 28, 2025
Closed
3 tasks
@yitzisnow yitzisnow mentioned this pull request Jul 8, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WittierDinosaur WittierDinosaur WittierDinosaur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New bigquery Union modifiers
2 participants
@Robin-C @WittierDinosaur