Fix tests with Click 8.2 #6706
Merged
Fix tests with Click 8.2 #6706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pallets/click#2523 introduced changes to `click.testing` that broke some unit tests in SQLFluff: `mix_stderr=False` is now effectively the default and can no longer be specified explicitly. In addition, pallets/click#1489 caused the diff-quality plugin to incorrectly believe that SQLFluff is not installed. Although this Click version hasn't been fully released yet, this adjusts SQLFluff to work with both old and new versions. Fixes: sqlfluff#6676
Coverage Results ✅ |
WittierDinosaur
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
pallets/click#2523 introduced changes to
click.testingthat broke some unit tests in SQLFluff:mix_stderr=Falseis now effectively the default and can no longer be specified explicitly.In addition, pallets/click#1489 caused the diff-quality plugin to incorrectly believe that SQLFluff is not installed.
Although this Click version hasn't been fully released yet, this adjusts SQLFluff to work with both old and new versions.
Fixes: #6676
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.ymlrule test cases intest/fixtures/rules/std_rule_cases..sql/.ymlparser test cases intest/fixtures/dialects(note YML files can be auto generated withtox -e generate-fixture-yml).test/fixtures/linter/autofix.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.