Skip to content

RF02: Add config for ignoring external references found in subqueries #6791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2025
Merged

RF02: Add config for ignoring external references found in subqueries #6791

merged 1 commit into from
Apr 16, 2025

Conversation

keraion
Copy link
Contributor

@keraion keraion commented Apr 7, 2025

Brief summary of the change made

This adds a configuration to RF02 which gives it a pre-#6091 option for subqueries.

Are there any other side effects of this change that we should be aware of?

None

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 7, 2025

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   19579      0   100%

249 files skipped due to complete coverage.

@joaocrebelo
Copy link

Hi @keraion - would this property also work to fix #6771?
In this case broadcast hints are inside comments, which should probably avoid triggering the rule by itself

@keraion
Copy link
Contributor Author

keraion commented Apr 15, 2025

@joaocrebelo in this case, no. I do have a fix I'm pulling together however to correct the linked issue.

WittierDinosaur
WittierDinosaur approved these changes Apr 16, 2025
View reviewed changes
Copy link
Contributor

@WittierDinosaur WittierDinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WittierDinosaur WittierDinosaur added this pull request to the merge queue Apr 16, 2025
Merged via the queue into main with commit 6a170ac Apr 16, 2025
30 checks passed
@WittierDinosaur WittierDinosaur deleted the rf02_subquery_config branch April 16, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WittierDinosaur WittierDinosaur WittierDinosaur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule references.qualification flags single-table subquery Unqualified references in uncorrelated subqueries
3 participants
@keraion @joaocrebelo @WittierDinosaur