Skip to content

Conversation

keraion
Copy link
Contributor

@keraion keraion commented Apr 7, 2025

Brief summary of the change made

This is a best effort on deploying the release docker images to ghcr.io in addition to docker hub.
The instructions have been replicated from here but still include the cached testing step.

Are there any other side effects of this change that we should be aware of?

This change can't be tested without an actual release (maybe 3.4.0 can be that?) so it may need a revisit if something has been incorrectly configured.

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

Copy link
Contributor

github-actions bot commented Apr 7, 2025

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   19576      0   100%

249 files skipped due to complete coverage.

Copy link
Member

@alanmcruickshank alanmcruickshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible. I guess we'll find out if it works!

@alanmcruickshank alanmcruickshank added this pull request to the merge queue Apr 8, 2025
Merged via the queue into main with commit 6708dfb Apr 8, 2025
30 checks passed
@alanmcruickshank alanmcruickshank deleted the publish_to_ghcr branch April 8, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish container images to ghcr.io in addition to dockerhub
2 participants