Skip to content

Snowflake dynamic table fixes #6748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 26, 2025
Merged

Snowflake dynamic table fixes #6748

merged 3 commits into from
Mar 26, 2025
+633 −256

Conversation

ulixius9
Copy link
Contributor

@ulixius9 ulixius9 commented Mar 26, 2025 •
edited
Loading

Brief summary of the change made

Are there any other side effects of this change that we should be aware of?

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@ulixius9 ulixius9 changed the title Snowflake dynamic table advance Snowflake dynamic table fixes Mar 26, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 26, 2025 •
edited
Loading

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   19354      0   100%

248 files skipped due to complete coverage.

dobsontom
dobsontom reviewed Mar 26, 2025
View reviewed changes
src/sqlfluff/dialects/dialect_snowflake.py Outdated
"AS",
OptionallyBracketed(Ref("SelectableGrammar")),
),
# Create like syntax
Sequence("LIKE", Ref("TableReferenceSegment")),
# Create clone syntax
Sequence("ClONE", Ref("TableReferenceSegment")),
Sequence(
"ClONE",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional lowercase l?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope - it'll be a typo

WittierDinosaur
WittierDinosaur reviewed Mar 26, 2025
View reviewed changes
WittierDinosaur
WittierDinosaur approved these changes Mar 26, 2025
View reviewed changes
Copy link
Contributor

@WittierDinosaur WittierDinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WittierDinosaur WittierDinosaur added this pull request to the merge queue Mar 26, 2025
Merged via the queue into sqlfluff:main with commit 2db1258 Mar 26, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WittierDinosaur WittierDinosaur WittierDinosaur approved these changes

+1 more reviewer

@dobsontom dobsontom dobsontom left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ulixius9 @WittierDinosaur @dobsontom