Skip to content

Python 3.9+ Type simplifications #6745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 26, 2025
Merged

Python 3.9+ Type simplifications #6745

merged 6 commits into from
Mar 26, 2025

Conversation

alanmcruickshank
Copy link
Member

Following on from #6743, this tidies up all the type annotations that used to use py3.8 compatible types. Much cleaner and much wider use of generics.

This PR is mostly find & replace, with only a few manual tweeks. No intended functionality changes.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 24, 2025 •
edited
Loading

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   19336      0   100%

248 files skipped due to complete coverage.

WittierDinosaur
WittierDinosaur approved these changes Mar 26, 2025
View reviewed changes
Copy link
Contributor

@WittierDinosaur WittierDinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - spot checked a few files, tests passing, low risk despite being a huge PR

@WittierDinosaur WittierDinosaur added this pull request to the merge queue Mar 26, 2025
Merged via the queue into main with commit 978e466 Mar 26, 2025
30 checks passed
@WittierDinosaur WittierDinosaur deleted the ac/py38 branch March 26, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WittierDinosaur WittierDinosaur WittierDinosaur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alanmcruickshank @WittierDinosaur