Skip to content

Drop support for Python 3.8 #6743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 23, 2025
Merged

Drop support for Python 3.8 #6743

merged 5 commits into from
Mar 23, 2025

Conversation

WittierDinosaur
Copy link
Contributor

Brief summary of the change made

Python 3.8 hit EOL in October 2024. 5 months on is probably a good time to drop support for it. It allows us to drop a dependency, there's probably some other code clean up we can do without it. This'll trigger a minor release.

Are there any other side effects of this change that we should be aware of?

About 2% of our downloads are still on Python 3.8. But this still seems like a reasonable time to stop developing new features for it.

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@WittierDinosaur WittierDinosaur added the minor release A PR or issue queued for minor release. label Mar 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 22, 2025 •
edited
Loading

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   19348      0   100%

248 files skipped due to complete coverage.

alanmcruickshank
alanmcruickshank approved these changes Mar 23, 2025
View reviewed changes
Copy link
Member

@alanmcruickshank alanmcruickshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - I think there are some other syntax bits that this unlocks but I'll kick off another PR to handle them. I've disabled the required 3.8 check in the branch protection rules.

@alanmcruickshank alanmcruickshank added this pull request to the merge queue Mar 23, 2025
Merged via the queue into main with commit 911a6eb Mar 23, 2025
30 checks passed
@alanmcruickshank alanmcruickshank deleted the remove-python38 branch March 23, 2025 12:06
@alanmcruickshank alanmcruickshank mentioned this pull request Mar 23, 2025
Merged
ulixius9 added a commit to open-metadata/collate-sqlfluff that referenced this pull request Mar 26, 2025
@ulixius9
Revert "Drop support for Python 3.8 (sqlfluff#6743)"
9a98b9c 
This reverts commit 911a6eb.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanmcruickshank alanmcruickshank alanmcruickshank approved these changes

Assignees
No one assigned
Labels
minor release A PR or issue queued for minor release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WittierDinosaur @alanmcruickshank