Skip to content

feat: Add missing parquet file format keywords to SF dialect #6638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 7, 2025
Merged

feat: Add missing parquet file format keywords to SF dialect #6638

merged 2 commits into from
Feb 7, 2025

Conversation

jjlkant
Copy link
Contributor

@jjlkant jjlkant commented Feb 6, 2025

Brief summary of the change made

Fixes #6637

Adds the missing unreserved keywords USE_LOGICAL_TYPE and USE_VECTORIZED_SCANNER to the Snowflake dialect keywords list. Also adds the missing boolean literal REPLACE_INVALID_CHARACTERS to the OneOf.

Are there any other side effects of this change that we should be aware of?

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

WittierDinosaur
WittierDinosaur approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@WittierDinosaur WittierDinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025 •
edited
Loading

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   19304      0   100%

248 files skipped due to complete coverage.

@WittierDinosaur WittierDinosaur added this pull request to the merge queue Feb 7, 2025
Merged via the queue into sqlfluff:main with commit 7b56a50 Feb 7, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WittierDinosaur WittierDinosaur WittierDinosaur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to parse Snowflake FILE_FORMAT parameter USE_LOGICAL_TYPE
2 participants
@jjlkant @WittierDinosaur