Skip to content

Add support for BigQuery LOAD DATA statement #6612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2025
Merged

Add support for BigQuery LOAD DATA statement #6612

merged 1 commit into from
Jan 30, 2025

Conversation

VMois
Copy link
Contributor

@VMois VMois commented Jan 29, 2025 •
edited
Loading

Brief summary of the change made

Adding support to LOAD DATA statement in BigQuery dialect.

closes #6589

Are there any other side effects of this change that we should be aware of?

Not that I am aware of. BigQuery parser tests passed successfully. Seems like the LOAD DATA statement did not break any other BigQuery statements.

Pull Request checklist

  • .sql/.yml parser test cases in test/fixtures/dialects. Used tox as described in the Contributing guide.
  • No follow-up issues are necessary.

@VMois VMois force-pushed the bigquery_add_load_data_statement branch from 2485801 to dd4c495 Compare January 29, 2025 02:25
VMois
VMois commented Jan 29, 2025
View reviewed changes
@VMois VMois force-pushed the bigquery_add_load_data_statement branch 2 times, most recently from c1a4f33 to 0d500bf Compare January 29, 2025 02:34
@VMois
Copy link
Contributor Author

VMois commented Jan 29, 2025

question: does adding support to a statement require updating any docs?

VMois
VMois commented Jan 29, 2025
View reviewed changes
@VMois VMois changed the title (WIP) Add support for BigQuery LOAD DATA statement. (#6589) Add support for BigQuery LOAD DATA statement Jan 29, 2025
@VMois VMois marked this pull request as ready for review January 29, 2025 02:40
@VMois VMois force-pushed the bigquery_add_load_data_statement branch from 0d500bf to a7070ad Compare January 29, 2025 02:45
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 29, 2025 •
edited
Loading

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   19281      0   100%

248 files skipped due to complete coverage.

keraion
keraion approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@keraion keraion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Overall, everything looks good. Thanks! 🎉

@keraion
Copy link
Contributor

keraion commented Jan 29, 2025

question: does adding support to a statement require updating any docs?

Nope, but including the dialect source documentation in the code like you did is always super helpful.

@keraion keraion added this pull request to the merge queue Jan 29, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 29, 2025
@VMois VMois force-pushed the bigquery_add_load_data_statement branch from a7070ad to ebbb7f4 Compare January 30, 2025 02:02
@VMois VMois force-pushed the bigquery_add_load_data_statement branch from ebbb7f4 to 5069fb9 Compare January 30, 2025 02:04
@VMois
Copy link
Contributor Author

VMois commented Jan 30, 2025

Addressed all nits. Rebased against main to get latest changes. All seems good. Not sure what is the merge process here. Will leave it up to the maintainers.

Thank you very much for the quick review. SQLFluff is great!

@keraion keraion added this pull request to the merge queue Jan 30, 2025
Merged via the queue into sqlfluff:main with commit dd8a57a Jan 30, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keraion keraion keraion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for LOAD INTO statement, BigQuery dialect
2 participants
@VMois @keraion