RF02: do not trigger on snowflake lambda anonymous parameters #6689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While I made this PR to specifically fix RF02, it should also fix RF03 as a side effect. |
5a092af to
13711e2
Compare
|
Fixed the yml testing files and added a test for rule RF03. |
13711e2 to
7ae9417
Compare
7ae9417 to
a13f412
Compare
Coverage Results ✅ |
auto-merge was automatically disabled
April 1, 2025 12:43
Head branch was pushed to by a user without write access
40f63aa to
4464b4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
fixes #6683
Allows RF02 to ignore anonymous parameters for Snowflake lambda expressions used in functions
transform,filter,reduce.Dialect parsing implementation for lambdas in Snowflake was different than for trino and duckdb.
Made changes to snowflake tokens to match trino and duckdb implementation, this allows for minimal change in rule checking.
With the modified tokens, simply adding snowflake to the list of dialects that support lambda expressions in
analysis/select.pyfixes RF02 to no longer trigger incorrectly.Are there any other side effects of this change that we should be aware of?
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.ymlrule test cases intest/fixtures/rules/std_rule_cases..sql/.ymlparser test cases intest/fixtures/dialects(note YML files can be auto generated withtox -e generate-fixture-yml).test/fixtures/linter/autofix.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.