Skip to content

Fill in Gap in Snowflake ALTER TABLE Parsing #6654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Mar 1, 2025
Merged

Fill in Gap in Snowflake ALTER TABLE Parsing #6654

merged 28 commits into from
Mar 1, 2025

Conversation

LoganPrice344
Copy link
Contributor

@LoganPrice344 LoganPrice344 commented Feb 12, 2025 •
edited
Loading

Fixes #6653

LoganPrice344 and others added 26 commits December 16, 2024 12:11
@LoganPrice344
Updated to allow variation in storage integration order
d12c3aa
@LoganPrice344
cleaned up
fdc9866
@LoganPrice344
Merge pull request #1 from LoganPrice344/lp-storage_integration
0049bef 
Added support for inverted syntax logic for create stage
@LoganPrice344
Merge branch 'main' into main
efbb03e
@LoganPrice344
Merge branch 'main' into main
ebee155
@LoganPrice344
fixing commit issues
8aba5e1
@LoganPrice344
Merge pull request #3 from LoganPrice344/lp_update_to_main
2fab792 
fixing commit issues
@LoganPrice344
Merge branch 'sqlfluff:main' into main
3cf82e5
@LoganPrice344
Merge https://github.com/sqlfluff/sqlfluff
bd740a6
@LoganPrice344
Merge branch 'main' of https://github.com/LoganPrice344/sqlfluff
9ea2115
@LoganPrice344
Merge branch 'main' into main
f36d6d3
@LoganPrice344
Merge branch 'main' into main
9ac9679
@LoganPrice344
Merge branch 'main' into main
c88a392
@WittierDinosaur
Merge branch 'main' into main
dc40d61
@LoganPrice344
Merge branch 'main' into main
779b68a
@LoganPrice344
Merge branch 'main' into main
685bca9
@LoganPrice344
Merge branch 'main' into main
f710341
@LoganPrice344
updated test
83d3ac7
@LoganPrice344
Merge branch 'main' into lp_main_patches
cd05266
@LoganPrice344
Merge pull request #4 from LoganPrice344/lp_main_patches
426fd9d 
Lp main patches
@LoganPrice344
Merge https://github.com/sqlfluff/sqlfluff
cdbf996
@LoganPrice344
Merge branch 'sqlfluff:main' into main
75ca192
@LoganPrice344
Merge branch 'main' of https://github.com/LoganPrice344/sqlfluff
3d1a34a
@LoganPrice344
First rendition
13d6f71
@LoganPrice344
added tests
5fbd986
@LoganPrice344
Merge branch 'main' into lp_alter_table_row_access
839887c
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 12, 2025 •
edited
Loading

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   19333      0   100%

248 files skipped due to complete coverage.

@LoganPrice344 LoganPrice344 changed the title Lp alter table row access Fill in Gap in Snowflake ALTER TABLE Parsing Feb 13, 2025
WittierDinosaur
WittierDinosaur reviewed Feb 15, 2025
View reviewed changes
WittierDinosaur
WittierDinosaur reviewed Feb 15, 2025
View reviewed changes
@WittierDinosaur
Copy link
Contributor

Merge conflicts with another of your PRs - can you resolve?

WittierDinosaur
WittierDinosaur approved these changes Mar 1, 2025
View reviewed changes
Copy link
Contributor

@WittierDinosaur WittierDinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WittierDinosaur WittierDinosaur added this pull request to the merge queue Mar 1, 2025
Merged via the queue into sqlfluff:main with commit 8816cbb Mar 1, 2025
29 checks passed
@moreaupascal56 moreaupascal56 mentioned this pull request Mar 19, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WittierDinosaur WittierDinosaur WittierDinosaur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gap in Snowflake ALTER TABLE Parsing
2 participants
@LoganPrice344 @WittierDinosaur