Skip to content

Fill in Gap in Snowflake ALTER TAG Syntax #6531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 8, 2025
Merged

Fill in Gap in Snowflake ALTER TAG Syntax #6531

merged 8 commits into from
Jan 8, 2025
+210 −0

Conversation

LoganPrice344
Copy link
Contributor

Fixes #6530

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 30, 2024 •
edited
Loading

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   19212      0   100%

248 files skipped due to complete coverage.

keraion
keraion reviewed Jan 8, 2025
View reviewed changes
Copy link
Contributor

@keraion keraion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small removal of a commented line.

@LoganPrice344 @keraion
Update src/sqlfluff/dialects/dialect_snowflake.py
e646578 
Co-authored-by: Cameron <105471409+keraion@users.noreply.github.com>
@LoganPrice344 LoganPrice344 requested a review from keraion January 8, 2025 15:08
@keraion
Copy link
Contributor

keraion commented Jan 8, 2025

This has merge conflicts. Please resolve.

keraion
keraion approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@keraion keraion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@keraion keraion added this pull request to the merge queue Jan 8, 2025
Merged via the queue into sqlfluff:main with commit e707341 Jan 8, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keraion keraion keraion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gap in Snowflake ALTER TAG Syntax
2 participants
@LoganPrice344 @keraion