Skip to content

fix: databricks describe volume recognition #6529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2025
Merged

fix: databricks describe volume recognition #6529

merged 1 commit into from
Jan 7, 2025

Conversation

benfdking
Copy link
Contributor

@benfdking benfdking commented Dec 28, 2024 •
edited
Loading

fix: databricks describe volume recognition

Brief summary of the change made

Added at=0 so that the Databricks parser doesn't mistakenly recognize Describe Volume as a Describe Table query.`

Are there any other side effects of this change that we should be aware of?

None that I am aware of.

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@benfdking benfdking changed the title fix: databricks volume recognition fix: databricks describe volume recognition Dec 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   19200      0   100%

248 files skipped due to complete coverage.

keraion
keraion approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@keraion keraion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@keraion keraion added this pull request to the merge queue Jan 7, 2025
Merged via the queue into sqlfluff:main with commit 4a3d06b Jan 7, 2025
28 of 29 checks passed
@benfdking benfdking deleted the benfdking/fix_databricks_volume_recognition branch January 16, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keraion keraion keraion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benfdking @keraion