Skip to content

ST03: Handle quotes in CTE names #6591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2025
Merged

ST03: Handle quotes in CTE names #6591

merged 1 commit into from
Jan 25, 2025

Conversation

keraion
Copy link
Contributor

@keraion keraion commented Jan 23, 2025

Brief summary of the change made

This allows for quotes to be in either the CTE name or the table_expression that references it (mix and match).

Are there any other side effects of this change that we should be aware of?

This touches the Query class and removes quotes from the ctes dictionary keys. This may reveal other opportunities to apply the quote change to other rules, but a cursory glance determined minimal impact.

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@github-actions GitHub Actions
Copy link
Contributor

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   19223      0   100%

248 files skipped due to complete coverage.

WittierDinosaur
WittierDinosaur approved these changes Jan 25, 2025
View reviewed changes
Copy link
Contributor

@WittierDinosaur WittierDinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WittierDinosaur WittierDinosaur added this pull request to the merge queue Jan 25, 2025
Merged via the queue into main with commit e1e685d Jan 25, 2025
31 checks passed
@WittierDinosaur WittierDinosaur deleted the ST03_quoted_ctes branch January 25, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WittierDinosaur WittierDinosaur WittierDinosaur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BigQuery CTE not recognised when quoting CTE name in FROM
2 participants
@keraion @WittierDinosaur